Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apm-mutating-webhook.asciidoc #85

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Update apm-mutating-webhook.asciidoc #85

merged 5 commits into from
Jan 9, 2024

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Dec 8, 2023

The .NET attacher is not GA and won't be until after 8.12.

I'm not sure if the "tech preview" message at the top will be removed for 8.12. If so, then we should mark only the .NET attacher as tech preview.

The .NET attacher is not GA and won't be until after 8.12
@github-actions github-actions bot added the apm-k8s-attacher Mutating Webhook to attach apm agents on k8s label Dec 8, 2023
@estolfo estolfo requested a review from bmorelli25 December 21, 2023 15:29
@bmorelli25
Copy link
Member

e9067c6 removes the preview admonition from the top of the page and adds an inline preview to the .NET agent line.
Screenshot 2024-01-02 at 1 35 10 PM

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to fix the failing ci check.

@estolfo
Copy link
Contributor Author

estolfo commented Jan 5, 2024

Replacing my previous comment: it has to do with the year in the notice file, I'll look into it. It might not be as simple as just updating the year.

@estolfo
Copy link
Contributor Author

estolfo commented Jan 8, 2024

@bmorelli25 I fixed that failing test, if you want to rebase

@bmorelli25
Copy link
Member

Checks are green. It looks like my approval isn't good enough to merge this PR.

@estolfo estolfo merged commit 0a1256f into main Jan 9, 2024
8 checks passed
@bmorelli25 bmorelli25 deleted the estolfo-patch-1 branch January 16, 2024 01:34
trentm added a commit that referenced this pull request Jul 19, 2024
…de pages

This is a follow-up to #85. This attacher is GA now.
trentm added a commit that referenced this pull request Jul 19, 2024
…de pages (#107)

This is a follow-up to #85. This attacher is GA now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm-k8s-attacher Mutating Webhook to attach apm agents on k8s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants