Skip to content

Commit

Permalink
test: drop redundant kind cluster creation in integration.yml workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
trentm committed Jan 8, 2024
1 parent c46a829 commit e4c5808
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 11 deletions.
15 changes: 6 additions & 9 deletions .github/workflows/integration.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Agents Integration Testing

on:
on:
workflow_dispatch:
push:
branches:
Expand All @@ -18,10 +18,10 @@ on:
paths-ignore:
- '**.md'
- '**.asciidoc'

env:
AGENT_TESTS: java nodejs

jobs:
integration-test:
runs-on: ubuntu-latest
Expand All @@ -31,15 +31,12 @@ jobs:
with:
fetch-depth: 0

- name: Create kind cluster
uses: helm/[email protected]

- name: Create Local Registry
run:
run:
sh test/mock/kind-with-registry.sh

- name: Create Mock APM server image
run:
run:
cd test/mock;
docker build -t mock-apm-server .;
docker tag mock-apm-server localhost:5001/registry/mock-apm-server;
Expand Down Expand Up @@ -72,7 +69,7 @@ jobs:
version: v3.11.2

- name: Install webhook
run:
run:
cd charts;
helm install webhook-chart apm-attacher/ --namespace=elastic-apm --create-namespace --values ../test/mock/test_values.yaml;
sleep 5;
Expand Down
4 changes: 2 additions & 2 deletions charts/apm-attacher/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ apiVersion: v2
name: apm-attacher
type: application
version: "0.1.0"
description: A Helm chart installing the Elastic APM mutating webhook.
description: A Helm chart installing the Elastic APM attacher (mutating webhook).
sources:
- https://github.com/elastic/apm-mutating-webhook
- https://github.com/elastic/apm-k8s-attacher
1 change: 1 addition & 0 deletions test/nodejs/deployment.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
# This file isn't currently used, but can be nice for manual testing or demos.
apiVersion: apps/v1
kind: Deployment
metadata:
Expand Down

0 comments on commit e4c5808

Please sign in to comment.