Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Enable running elastic-agent with --bc #1011

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Conversation

axw
Copy link
Member

@axw axw commented Dec 21, 2020

What does this PR do?

Override build_candidate_manifest in the ElasticAgent class, so we look in the right place for the elastic-agent image.

Why is it important?

This enables running elastic-agent when using the --bc flag.

Related issues

None.

Override build_candidate_manifest in the ElasticAgent
class, so we look in the right place for the elastic-agent
image. This enables running elastic-agent when using
the "--bc" flag.
@axw axw requested a review from simitt December 21, 2020 08:58
@apmmachine
Copy link
Collaborator

apmmachine commented Dec 21, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Started by timer

  • Start Time: 2020-12-22T04:45:00.811+0000

  • Duration: 33 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 442
Skipped 12
Total 454

@axw axw marked this pull request as draft December 21, 2020 09:59
@axw
Copy link
Member Author

axw commented Dec 21, 2020

Hold off on reviewing. We need to configure elastic-agent to download from the staging.elastic.co URL.

We should be doing that, but I don't know how we can. elastic-agent enroll wants to rename the config file, and that doesn't play nicely with bind mounting a volume in. So let's do that later.

@axw axw marked this pull request as ready for review December 21, 2020 10:35
@axw
Copy link
Member Author

axw commented Dec 22, 2020

jenkins run the tests please

@axw axw merged commit 8570aba into elastic:master Dec 22, 2020
@axw axw deleted the elastic-agent-bc branch December 22, 2020 05:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants