Add support for providing host.id via intakeV2. #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kruskall
previously approved these changes
Apr 5, 2024
carsonip
reviewed
Apr 5, 2024
Co-authored-by: Carson Ip <[email protected]>
carsonip
previously approved these changes
Apr 5, 2024
kruskall
approved these changes
Apr 5, 2024
|
@kruskall can you merge the PR for me? I don't have the permissions to do so |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for elastic/apm#853, closes #187 .
We already support the OpenTelemetry Resource Attribute host.id via the OTLP intake. Because this field is required for the universal profiling correlation, we need to be able to set that field via
IntakeV2.This PR therefore adds the optional
host_idas new IntakeV2 metadata field.