feat: map OTEL's span.status: Unset to event.outcome: success
#188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
reviewed
Dec 4, 2023
kyungeunni
commented
Dec 5, 2023
| @@ -174,9 +174,16 @@ func TestDecodeMapToSpanModel(t *testing.T) { | |||
| assert.Equal(t, "failure", out.Event.Outcome) | |||
| // derive from other fields - unknown | |||
| input.Outcome.Reset() | |||
| input.OTel.Reset() | |||
There was a problem hiding this comment.
The change was only made to OTel input for now, so I needed to reset the Otel attributes here so we don't get confused why it affects also elasticapm input
kyungeunni
commented
Dec 5, 2023
| input.Context.HTTP.StatusCode.Reset() | ||
| mapToSpanModel(&input, &out) | ||
| assert.Equal(t, "unknown", out.Event.Outcome) | ||
| // outcome is success when not assigned and it's otel | ||
| input.Outcome.Reset() | ||
| input.OTel.SpanKind.Set(spanKindInternal) |
There was a problem hiding this comment.
The change was only made to OTel input for now, if otel attributes are set, it will use the same logic for mapping the Unset status to success outcome
marclop
approved these changes
Dec 11, 2023
2 tasks
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apm-data translates
Span.status: Unsetasevent.outcome: unknown. For OTEL, Unset status implies has not been failed/errored. We'd like to map Unset to success so we can calculate the correct transaction failed rate.The OTel specification writes the following on the SpanStatus being Unset:
So it should be ok for us map the Unset to success when we process the data.