-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rum-core): add serverUrlPrefix config option #1081
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, can you add test here - https://github.com/elastic/apm-agent-rum-js/blob/master/packages/rum-core/test/common/apm-server.spec.js and also add docs on the new flag - https://github.com/elastic/apm-agent-rum-js/blob/master/docs/configuration.asciidoc
/test |
@elasticmachine, run elasticsearch-ci/docs |
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @alexbode !
@alexbode Can you rebase your commits with |
📦 Bundlesize report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks 🎉
Co-authored-by: alexbode <[email protected]>
Change hardcoded serverUrlPrefix to passable parameter to evade ad blockers
fixes issue #1078