Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rum-core): add serverUrlPrefix config option #1081

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

alexbode
Copy link
Contributor

Change hardcoded serverUrlPrefix to passable parameter to evade ad blockers

fixes issue #1078

@apmmachine
Copy link
Contributor

apmmachine commented Sep 28, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-21T04:02:59.959+0000

  • Duration: 76 min 34 sec

  • Commit: 7372aa9

Test stats 🧪

Test Results
Failed 0
Passed 1065
Skipped 9
Total 1074

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vigneshshanmugam
Copy link
Member

/test

@bmorelli25
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@bmorelli25
Copy link
Member

jenkins test this please

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @alexbode !

@vigneshshanmugam vigneshshanmugam changed the title feat: Add serverUrlPrefix feat(rum-core): add serverUrlPrefix config option Oct 7, 2021
@vigneshshanmugam
Copy link
Member

@alexbode Can you rebase your commits with feat(rum-core): add serverUrlPrefix config option just to make sure the tests get picked up and lint pass.

@apmmachine
Copy link
Contributor

📦 Bundlesize report

Filename Size(bundled) Size(gzip) Diff(gzip)
elastic-apm-opentracing.umd.min.js 63.3 KiB 20.2 KiB ⚠️ 19 Bytes
elastic-apm-rum.umd.min.js 57.2 KiB 18.7 KiB ⚠️ 20 Bytes

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks 🎉

@vigneshshanmugam vigneshshanmugam merged commit cf407b4 into elastic:master Oct 21, 2021
@vigneshshanmugam vigneshshanmugam mentioned this pull request Nov 18, 2021
vigneshshanmugam pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants