Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add transaction_ignore_urls config #844

Merged
merged 2 commits into from
Aug 10, 2020
Merged

Add transaction_ignore_urls config #844

merged 2 commits into from
Aug 10, 2020

Conversation

mikker
Copy link
Contributor

@mikker mikker commented Aug 6, 2020

Close #835

Add transaction_ignore_urls config
c5d8703 
Soft deprecates ignore_url_patterns
@mikker mikker self-assigned this Aug 6, 2020
@apmmachine
Copy link
Contributor

apmmachine commented Aug 6, 2020 •
edited
Loading

💔 Tests Failed

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #844 updated]

  • Start Time: 2020-08-06T10:51:44.554+0000

  • Duration: 31 min 2 sec

Test stats 🧪

Test Results
Failed 1
Passed 59462
Skipped 0
Total 59463

Test errors

Expand to view the tests failures

  • Name: Tests / Master Tests frameworks / Ruby:ruby:2.7#rails-master / Rails paths sets the paths – Rails paths

    • Age: 1
    • Duration: 0.28767377
    • Error Details: failed Rails paths sets the paths

Steps errors

Expand to view the steps failures

  • Name: Shell Script

    • Description: ./spec/scripts/spec.sh ruby:2.7 sinatra-1.4

    • Duration: 2 min 40 sec

    • Start Time: 2020-08-06T10:58:47.725+0000

    • log

  • Name: Shell Script

    • Description: ./spec/scripts/spec.sh ruby:2.7 grape-1.3,sinatra-2.0,rails-6.0

    • Duration: 3 min 42 sec

    • Start Time: 2020-08-06T10:58:43.128+0000

    • log

  • Name: Shell Script

    • Description: ./spec/scripts/spec.sh ruby:2.5 sinatra-1.4

    • Duration: 1 min 24 sec

    • Start Time: 2020-08-06T11:00:13.760+0000

    • log

  • Name: Shell Script

    • Description: ./spec/scripts/spec.sh ruby:2.3 sinatra-2.0

    • Duration: 2 min 41 sec

    • Start Time: 2020-08-06T10:58:56.086+0000

    • log

  • Name: Shell Script

    • Description: ./spec/scripts/spec.sh jruby:9.1 sinatra-1.4

    • Duration: 3 min 21 sec

    • Start Time: 2020-08-06T11:00:13.088+0000

    • log

  • Name: Shell Script

    • Description: [2020-08-06T10:58:47.135Z] + ./spec/scripts/spec.sh docker.elastic.co/observability-ci/jruby:9.2-13-

    • Duration: 7 min 3 sec

    • Start Time: 2020-08-06T10:58:46.840+0000

    • log

  • Name: Shell Script

    • Description: [2020-08-06T10:59:55.106Z] + ./spec/scripts/spec.sh docker.elastic.co/observability-ci/jruby:9.2-8-j

    • Duration: 6 min 17 sec

    • Start Time: 2020-08-06T10:59:54.806+0000

    • log

  • Name: Shell Script

    • Description: [2020-08-06T11:00:15.250Z] + ./spec/scripts/spec.sh docker.elastic.co/observability-ci/jruby:9.1-7-j

    • Duration: 8 min 55 sec

    • Start Time: 2020-08-06T11:00:14.957+0000

    • log

  • Name: Shell Script

    • Description: ./spec/scripts/spec.sh ruby:2.7 rails-master

    • Duration: 3 min 27 sec

    • Start Time: 2020-08-06T10:59:15.636+0000

    • log

  • Name: Shell Script

    • Description: ./spec/scripts/spec.sh ruby:2.7 rails-master

    • Duration: 3 min 0 sec

    • Start Time: 2020-08-06T11:03:18.060+0000

    • log

  • Name: Error signal

    • Description: Ruby:ruby:2.7#rails-master tests failed : hudson.AbortException: script returned exit code 1

    • Duration: 0 min 0 sec

    • Start Time: 2020-08-06T11:06:18.459+0000

    • log

Log output

Expand to view the last 100 lines of log output 

[2020-08-06T11:22:34.124Z] Installing rubocop-ast 0.3.0
[2020-08-06T11:22:34.384Z] Fetching webmock 3.8.3
[2020-08-06T11:22:34.643Z] Installing webmock 3.8.3
[2020-08-06T11:22:34.643Z] Fetching domain_name 0.5.20190701
[2020-08-06T11:22:34.904Z] Fetching http-parser 1.2.1
[2020-08-06T11:22:34.904Z] Installing domain_name 0.5.20190701
[2020-08-06T11:22:34.904Z] Installing http-parser 1.2.1 with native extensions
[2020-08-06T11:22:34.904Z] Fetching elasticsearch-transport 7.8.1
[2020-08-06T11:22:34.904Z] Installing elasticsearch-transport 7.8.1
[2020-08-06T11:22:35.843Z] Fetching grpc 1.30.2 (x86_64-linux)
[2020-08-06T11:22:35.843Z] Fetching sinatra 2.0.8.1
[2020-08-06T11:22:35.843Z] Fetching rspec-its 1.3.0
[2020-08-06T11:22:36.103Z] Installing rspec-its 1.3.0
[2020-08-06T11:22:36.103Z] Fetching rspec 3.9.0
[2020-08-06T11:22:36.103Z] Installing sinatra 2.0.8.1
[2020-08-06T11:22:36.103Z] Installing rspec 3.9.0
[2020-08-06T11:22:36.103Z] Fetching sneakers 2.12.0
[2020-08-06T11:22:36.103Z] Fetching simplecov-cobertura 1.3.1
[2020-08-06T11:22:36.103Z] Installing sneakers 2.12.0
[2020-08-06T11:22:36.103Z] Installing simplecov-cobertura 1.3.1
[2020-08-06T11:22:36.103Z] Fetching rubocop 0.89.0
[2020-08-06T11:22:36.374Z] Fetching protobuf-cucumber 3.10.8
[2020-08-06T11:22:36.634Z] Installing protobuf-cucumber 3.10.8
[2020-08-06T11:22:36.634Z] Installing rubocop 0.89.0
[2020-08-06T11:22:37.202Z] Fetching aws-sdk-dynamodb 1.51.0
[2020-08-06T11:22:37.202Z] Installing aws-sdk-dynamodb 1.51.0
[2020-08-06T11:22:37.462Z] Fetching aws-sdk-sqs 1.30.0
[2020-08-06T11:22:37.462Z] Installing aws-sdk-sqs 1.30.0
[2020-08-06T11:22:37.462Z] Fetching shoryuken 5.0.4
[2020-08-06T11:22:37.722Z] Installing shoryuken 5.0.4
[2020-08-06T11:22:37.722Z] Fetching http-cookie 1.0.3
[2020-08-06T11:22:37.722Z] Fetching elasticsearch 7.8.1
[2020-08-06T11:22:37.982Z] Installing grpc 1.30.2 (x86_64-linux)
[2020-08-06T11:22:37.982Z] Installing http-cookie 1.0.3
[2020-08-06T11:22:37.982Z] Installing elasticsearch 7.8.1
[2020-08-06T11:22:38.241Z] Fetching yarjuf 2.0.0
[2020-08-06T11:22:38.241Z] Fetching resque 2.0.0
[2020-08-06T11:22:38.241Z] Installing yarjuf 2.0.0
[2020-08-06T11:22:38.241Z] Fetching cucumber-messages 12.4.0
[2020-08-06T11:22:38.241Z] Installing resque 2.0.0
[2020-08-06T11:22:38.241Z] Installing cucumber-messages 12.4.0
[2020-08-06T11:22:38.500Z] Fetching rubocop-performance 1.7.1
[2020-08-06T11:22:38.500Z] Fetching http 4.4.1
[2020-08-06T11:22:38.760Z] Installing rubocop-performance 1.7.1
[2020-08-06T11:22:38.760Z] Installing http 4.4.1
[2020-08-06T11:22:38.760Z] Fetching cucumber-gherkin 14.2.0
[2020-08-06T11:22:38.760Z] Fetching cucumber-create-meta 1.0.0
[2020-08-06T11:22:38.760Z] Installing cucumber-gherkin 14.2.0
[2020-08-06T11:22:39.020Z] Fetching cucumber-html-formatter 7.2.0
[2020-08-06T11:22:39.020Z] Installing cucumber-create-meta 1.0.0
[2020-08-06T11:22:39.020Z] Using elastic-apm 3.9.0 from source at `.`
[2020-08-06T11:22:39.020Z] Fetching cucumber-core 7.1.0
[2020-08-06T11:22:39.020Z] Installing cucumber-core 7.1.0
[2020-08-06T11:22:39.020Z] Installing cucumber-html-formatter 7.2.0
[2020-08-06T11:22:39.280Z] Fetching cucumber-wire 3.1.0
[2020-08-06T11:22:39.280Z] Installing cucumber-wire 3.1.0
[2020-08-06T11:22:39.280Z] Fetching cucumber 4.1.0
[2020-08-06T11:22:39.539Z] Installing cucumber 4.1.0
[2020-08-06T11:22:39.799Z] Bundle complete! 35 Gemfile dependencies, 117 gems now installed.
[2020-08-06T11:22:39.799Z] Bundled gems are installed into `./vendor/2.7`
[2020-08-06T11:22:39.799Z] Post-install message from i18n:
[2020-08-06T11:22:39.799Z] 
[2020-08-06T11:22:39.799Z] HEADS UP! i18n 1.1 changed fallbacks to exclude default locale.
[2020-08-06T11:22:39.799Z] But that may break your application.
[2020-08-06T11:22:39.799Z] 
[2020-08-06T11:22:39.799Z] If you are upgrading your Rails application from an older version of Rails:
[2020-08-06T11:22:39.799Z] 
[2020-08-06T11:22:39.799Z] Please check your Rails app for 'config.i18n.fallbacks = true'.
[2020-08-06T11:22:39.799Z] If you're using I18n (>= 1.1.0) and Rails (< 5.2.2), this should be
[2020-08-06T11:22:39.799Z] 'config.i18n.fallbacks = [I18n.default_locale]'.
[2020-08-06T11:22:39.799Z] If not, fallbacks will be broken in your app by I18n 1.1.x.
[2020-08-06T11:22:39.799Z] 
[2020-08-06T11:22:39.799Z] If you are starting a NEW Rails application, you can ignore this notice.
[2020-08-06T11:22:39.799Z] 
[2020-08-06T11:22:39.799Z] For more info see:
[2020-08-06T11:22:39.799Z] https://github.com/svenfuchs/i18n/releases/tag/v1.1.0
[2020-08-06T11:22:39.799Z] 
[2020-08-06T11:22:39.799Z] Post-install message from sucker_punch:
[2020-08-06T11:22:39.799Z] Sucker Punch v2.0 introduces backwards-incompatible changes.
[2020-08-06T11:22:39.799Z] Please see https://github.com/brandonhilkert/sucker_punch/blob/master/CHANGES.md#200 for details.
[2020-08-06T11:22:42.337Z] Coverage report generated for RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec, RSpec to /app/coverage/coverage.xml
[2020-08-06T11:22:42.924Z] [Cobertura] Publishing Cobertura coverage report...
[2020-08-06T11:22:42.924Z] 
[2020-08-06T11:22:43.159Z] [Cobertura] Publishing Cobertura coverage results...
[2020-08-06T11:22:43.159Z] 
[2020-08-06T11:22:43.166Z] [Cobertura] Cobertura coverage report found.
[2020-08-06T11:22:43.166Z] 
[2020-08-06T11:22:44.777Z] Stage "Benchmarks" skipped due to when conditional
[2020-08-06T11:22:44.791Z] Stage "Benchmarks" skipped due to when conditional
[2020-08-06T11:22:44.821Z] Stage "Benchmarks" skipped due to when conditional
[2020-08-06T11:22:44.871Z] Stage "Release" skipped due to when conditional
[2020-08-06T11:22:44.884Z] Stage "Release" skipped due to when conditional
[2020-08-06T11:22:44.911Z] Stage "Release" skipped due to when conditional
[2020-08-06T11:22:44.937Z] Stage "Release" skipped due to when conditional
[2020-08-06T11:22:45.581Z] Running on Jenkins in /var/lib/jenkins/workspace/t-ruby_apm-agent-ruby-mbp_PR-844
[2020-08-06T11:22:45.618Z] [INFO] getVaultSecret: Getting secrets
[2020-08-06T11:22:45.684Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-08-06T11:22:46.328Z] + chmod 755 generate-build-data.sh
[2020-08-06T11:22:46.328Z] + ./generate-build-data.sh https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-ruby/apm-agent-ruby-mbp/PR-844/ https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-ruby/apm-agent-ruby-mbp/PR-844/runs/2 UNSTABLE 1861516
[2020-08-06T11:22:51.523Z] INFO: curl https://apm-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/apm-agent-ruby/apm-agent-ruby-mbp/PR-844/runs/2/steps/?limit=10000 -o steps-info.json

@mikker mikker added this to the 7.10 milestone Aug 6, 2020
@mikker mikker merged commit e20f48f into elastic:master Aug 10, 2020
@mikker mikker deleted the issue-835 branch August 10, 2020 07:07
@mikker
Copy link
Contributor Author

mikker commented Aug 10, 2020

Test error unrelated

@felixbarny
Copy link
Member

Nice work Mikkel! Would it be feasible for you to implement this test suite? elastic/apm#144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikker mikker

Labels
None yet
Projects
None yet
Milestone
7.10
Development

Successfully merging this pull request may close these issues.

Implement transaction_ignore_urls
3 participants
@mikker @apmmachine @felixbarny