docs: add dynamic badge to configuration options #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmorelli25
commented
Apr 9, 2020
|
|
||
| The recommended way to configure Elastic APM is to create a file | ||
| `config/elastic_apm.yml` and specify options in there: | ||
| The recommended way is to specify options in a `config/elastic_apm.yml` file: |
There was a problem hiding this comment.
Is this still the recommend way?
bmorelli25
commented
Apr 9, 2020
| @@ -192,6 +205,9 @@ went wrong. | |||
| [float] | |||
| [[config-api-request-size]] | |||
| ==== `api_request_size` | |||
|
|
|||
| <<dynamic-configuration, image:./images/dynamic-config.svg[] >> | |||
There was a problem hiding this comment.
These badges are also links to the <> section
|
I'm going to merge this, but I'm happy to make changes later if you have feedback. |
|
Sorry @bmorelli25 we had a holiday in Germany last Friday until today so I didn't get a chance to review this. I'll review it and open a PR if I see anything that should be changed. |
v1v
added a commit
to v1v/apm-agent-ruby
that referenced
this pull request
Apr 21, 2020
…release * upstream/master: (24 commits) Ensure that a new central config fetch is scheduled after network error (elastic#772) Updates to Resque support and documentation (elastic#768) Support recording config option (elastic#765) Add tests and adjustments to classes that can be restarted (elastic#766) Ensure that the running agent's config is used when restarted (elastic#763) The enabled tag is config-enabled Add enabled config option replacing active (elastic#762) docs: add dynamic badge (elastic#760) Config values set to false should be false, not nil (elastic#761) Add changelog entry for updating log level on config's logger Add changelog entry for logging updated remote config values Add changelog entry for dynamic config values Check if env variable exists before setting up SimpleCov (elastic#759) Log the updated options from central config in addition to cumulative modifications (elastic#758) ci(jenkins): merge branch in downstream jobs (elastic#757) Log level on logger is updated when Config options are (elastic#755) Cobertura coverage (elastic#736) Allow Config values to be dynamic (elastic#747) Reorder checks in test in case values are being cleared before checked (elastic#743) ci(jenkins): disable stages for only docs (elastic#745) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
This PR adds the
Dynamicbadge to supported configurations. I defined "supported configurations" as options that are supported by the Apm app.api_request_sizeapi_request_timecapture_bodycapture_headerslog_levelspan_frames_min_durationtransaction_max_spanstransaction_sample_rateThere is a discrepancy between the list above, and the list created by @estolfo in #741:
recordingdoesn't seem to be a valid option yet.Documentation preview
http://apm-agent-ruby_760.docs-preview.app.elstc.co/diff
Screenshot
Related issues
For elastic/apm#232
For https://github.com/elastic/observability-dev/issues/639