refactor: remove built in payload truncation logic #498
+3
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
commented
Aug 6, 2018
| @@ -37,7 +37,7 @@ test('extract URL from request', function (t) { | |||
| t.equal(request.url.search, '?foo=bar') | |||
| t.equal(request.url.raw, '/captureError?foo=bar') | |||
| t.equal(request.url.hostname, 'localhost') | |||
| t.equal(request.url.port, String(server.info.port)) | |||
There was a problem hiding this comment.
🤔 Previously, the act of truncating this property would convert it to a string. Now that truncation isn't part of this module any more, it's a number. But that's technically not a legal type for this property according to the intake API JSON spec:
Should the JSON spec allow for a number here?
There was a problem hiding this comment.
Why do we even truncate ports? They can't ever be longer than 5 digits. 🤔
There was a problem hiding this comment.
When implementing the truncation logic, I just went over all strings that had a limit on them and added the truncation.
Using a filter the user can overwrite it with anything they want. You could argue though that if they did the server JSON schema validation would just reject it, so it might not be that important.
There was a problem hiding this comment.
In related news, I realized the other day that process.title cannot be more than 16 bytes on Linux
|
The CI failures are because of the npm bug with the github link in the dependencies |
Qard
approved these changes
Aug 8, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
Qard
approved these changes
Aug 9, 2018
watson
added a commit
that referenced
this pull request
Aug 10, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
that referenced
this pull request
Aug 29, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
Qard
pushed a commit
to Qard/apm-agent-nodejs
that referenced
this pull request
Aug 30, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
that referenced
this pull request
Aug 30, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
that referenced
this pull request
Sep 6, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
that referenced
this pull request
Sep 13, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
that referenced
this pull request
Oct 19, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Oct 27, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
Qard
pushed a commit
that referenced
this pull request
Oct 31, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 6, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
that referenced
this pull request
Nov 6, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
Qard
pushed a commit
that referenced
this pull request
Nov 8, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
that referenced
this pull request
Nov 10, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Nov 13, 2018
This will instead be handled by the elastic-apm-http-client module in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for intake API v2.
Depends on elastic/apm-nodejs-http-client#8
This will instead be handled by the elastic-apm-http-client module when the above PR have been merged.