test: lock Node.js v18 testing to v18.18.2 as a workaround for IITM double-import issue #3783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ouble-import issue In Nodejs v18.19.0 ESM module loading was moved to being off-thread (a backport from Node.js v20, nodejs/node#44710). This breaks current import-in-the-middle usage, resulting in ESM modules being double-loaded when the IITM hook is active (once on the loader worker thread, and then again later on the main thread). This change is a workaround to skip testing recent Node.js v18 versions until the IITM issue is resolved..
github-actions
bot
added
the
agent-nodejs
david-luna
approved these changes
Dec 11, 2023
|
/test tav knex |
trentm
added a commit
that referenced
this pull request
Jan 11, 2024
…ouble-import issue (#3783) In Nodejs v18.19.0 ESM module loading was moved to being off-thread (a backport from Node.js v20, nodejs/node#44710). This breaks current import-in-the-middle usage, resulting in ESM modules being double-loaded when the IITM hook is active (once on the loader worker thread, and then again later on the main thread). This change is a workaround to skip testing recent Node.js v18 versions until the IITM issue is resolved. Refs: #3784
trentm
added a commit
that referenced
this pull request
Jan 11, 2024
…ouble-import issue (#3824) (backport of #3783) In Nodejs v18.19.0 ESM module loading was moved to being off-thread (a backport from Node.js v20, nodejs/node#44710). This breaks current import-in-the-middle usage, resulting in ESM modules being double-loaded when the IITM hook is active (once on the loader worker thread, and then again later on the main thread). This change is a workaround to skip testing recent Node.js v18 versions until the IITM issue is resolved. Refs: #3784
fpm-peter
pushed a commit
to fpm-git/apm-agent-nodejs
that referenced
this pull request
Aug 20, 2024
…ouble-import issue (elastic#3783) In Nodejs v18.19.0 ESM module loading was moved to being off-thread (a backport from Node.js v20, nodejs/node#44710). This breaks current import-in-the-middle usage, resulting in ESM modules being double-loaded when the IITM hook is active (once on the loader worker thread, and then again later on the main thread). This change is a workaround to skip testing recent Node.js v18 versions until the IITM issue is resolved. Refs: elastic#3784
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Nodejs v18.19.0 ESM module loading was moved to being off-thread
(a backport from Node.js v20, nodejs/node#44710).
This breaks current import-in-the-middle usage, resulting in ESM modules
being double-loaded when the IITM hook is active (once on the loader
worker thread, and then again later on the main thread).
This change is a workaround to skip testing recent Node.js v18
versions until the IITM issue is resolved.
Refs: #3784