Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graphql@16 has peer dep conflicts with [email protected] #2774

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented Jun 14, 2022

This peer dep conflict breaks our dist build (make -C .ci dist).
Fix the conflict by backing up to graphql@15 for now -- until we
separate out testing deps to separate package dirs, or until
express-graphql updates to support graphql@16.
We still test graphql@16 with our TAV tests.

Fixes: #2773

This peer dep conflict breaks our dist build (make -C .ci dist).
Fix the conflict by backing up to graphql@15 for now -- until we
separate out testing deps to separate package dirs, or until
express-graphql updates to support graphql@16.
We still test graphql@16 with our TAV tests.

Fixes: #2773
@trentm trentm requested a review from astorm June 14, 2022 16:14
@trentm trentm self-assigned this Jun 14, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jun 14, 2022
@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-14T16:14:24.955+0000

  • Duration: 22 min 5 sec

Test stats 🧪

Test Results
Failed 0
Passed 258073
Skipped 0
Total 258073

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm trentm merged commit fa7d947 into main Jun 14, 2022
@trentm trentm deleted the trentm/fix-graphl-peer-dep-conflicts branch June 14, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graphql@16 conflicts with [email protected] peerDependencies, breaking dist build
3 participants