Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure correct run context for 'cassandra-driver' instrumentation #2549

Merged
merged 2 commits into from
Jan 27, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented Jan 26, 2022

Refs: #2430

Checklist

  • Implement code
  • Add tests
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@trentm trentm self-assigned this Jan 26, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jan 26, 2022
@trentm
Copy link
Member Author

trentm commented Jan 26, 2022

The parent-child relationships from a run of examples/trace-cassandra-driver.js, before the run context fixes here:

    trace f40047
    `- transaction 7be43a "t1" (265.315ms, outcome=unknown)
       `- span 2d0073 "Cassandra: Connect" (41.431ms)
         `- span f24f13 "SELECT FROM system.local" (5.716ms)
           `- span ea5145 "CREATE" (1.807ms)
             `- span 8a1b0f "CREATE TABLE IF" (58.492ms)
               `- span 6c6f4c "Cassandra: Batch query" (36.157ms)
                 `- span a940e2 "Cassandra: Connect" (32.173ms)
                   `- span 1902a4 "SELECT FROM testtable" (3.387ms)
                     `- span 8679a9 "SELECT FROM testtable" (5.291ms)
                       `- span 296225 "DROP TABLE testtable" (99.723ms)

and after:

    trace 510b5e
    `- transaction 486ec1 "t1" (296.725ms, outcome=unknown)
       `- span d0d033 "Cassandra: Connect" (45.644ms)
       `- span 9d0350 "SELECT FROM system.local" (5.321ms)
       `- span 16ba1c "CREATE" (23.662ms)
       `- span 408cfd "CREATE TABLE IF" (44.923ms)
       `- span cb0d75 "Cassandra: Batch query" (36.014ms)
       `- span 8a037a "Cassandra: Connect" (31.812ms)
       `- span a1dfa7 "SELECT FROM testtable" (3.676ms)
       `- span 8b5d32 "SELECT FROM testtable" (3.573ms)
       `- span 7f117d "DROP TABLE testtable" (120.867ms)

@apmmachine
Copy link
Contributor

apmmachine commented Jan 26, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-26T21:08:30.133+0000

  • Duration: 51 min 38 sec

  • Commit: dd3ace1

Test stats 🧪

Test Results
Failed 0
Passed 243225
Skipped 0
Total 243225

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member Author

trentm commented Jan 26, 2022

run module tests for cassandra-driver

@trentm trentm marked this pull request as ready for review January 26, 2022 22:27
@trentm trentm requested a review from astorm January 26, 2022 22:27
astorm
astorm previously approved these changes Jan 27, 2022
@trentm trentm merged commit bb32bc2 into main Jan 27, 2022
@trentm trentm deleted the trentm/run-context-cassandra branch January 27, 2022 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants