Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.25.0 #2466

Merged
merged 3 commits into from
Nov 24, 2021
Merged

3.25.0 #2466

merged 3 commits into from
Nov 24, 2021

Conversation

trentm
Copy link
Member

@trentm trentm commented Nov 23, 2021

We have some improvements to release and this will allow us to get a fix for a broken link in the "current" published version of the docs (see #2465 (comment)).

@trentm trentm requested a review from astorm November 23, 2021 23:14
@trentm trentm self-assigned this Nov 23, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Nov 23, 2021
astorm
astorm previously approved these changes Nov 23, 2021
Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending CI pass

@trentm
Copy link
Member Author

trentm commented Nov 23, 2021

New test failure:

running (cwd: ./): node --unhandled-rejections=strict test/instrumentation/modules/@elastic/elasticsearch-canary.test.js
...
not ok 137 elasticsearch span has correct .context.db
  ---
    operator: deepEqual
    expected: |-
      { type: 'elasticsearch', statement: '{"query":{"match":{"request":"bar"}},"size":2,"sort":"myField:asc"}' }
    actual: |-
      { type: 'elasticsearch', statement: 'sort=myField%3Aasc\n\n{"query":{"match":{"request":"bar"}},"size":2}' }
    at: <anonymous> (/home/runner/work/apm-agent-nodejs/apm-agent-nodejs/test/instrumentation/modules/@elastic/elasticsearch.test.js:756:9)
    stack: |-
      Error: elasticsearch span has correct .context.db
          at Test.assert [as _assert] (/home/runner/work/apm-agent-nodejs/apm-agent-nodejs/node_modules/tape/lib/test.js:311:54)
          at Test.bound [as _assert] (/home/runner/work/apm-agent-nodejs/apm-agent-nodejs/node_modules/tape/lib/test.js:96:32)
          at Test.tapeDeepEqual (/home/runner/work/apm-agent-nodejs/apm-agent-nodejs/node_modules/tape/lib/test.js:552:10)
          at Test.bound [as deepEqual] (/home/runner/work/apm-agent-nodejs/apm-agent-nodejs/node_modules/tape/lib/test.js:96:32)
          at /home/runner/work/apm-agent-nodejs/apm-agent-nodejs/test/instrumentation/modules/@elastic/elasticsearch.test.js:756:9
          at Timeout._onTimeout (/home/runner/work/apm-agent-nodejs/apm-agent-nodejs/test/_mock_http_client.js:65:7)
          at listOnTimeout (internal/timers.js:549:17)
          at processTimers (internal/timers.js:492:7)
  ...

This changed behaviour between @elastic/[email protected] and @elastic/[email protected]. Fun fun.

They were released earlier today, so the timing makes sense:

$ npm info -j @elastic/elasticsearch-canary
...
    "8.0.0-canary.36": "2021-11-23T11:10:30.254Z",
    "8.0.0-canary.37": "2021-11-23T13:12:31.383Z"

@apmmachine
Copy link
Contributor

apmmachine commented Nov 23, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-24T00:14:21.435+0000

  • Duration: 78 min 12 sec

  • Commit: 2bbf212

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 8
Total 10

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member Author

trentm commented Nov 24, 2021

I manually started TAV and edge tests for this branch: https://apm-ci.elastic.co/job/apm-agent-nodejs/job/apm-agent-nodejs-mbp/job/PR-2466/3/

@trentm trentm merged commit 832c285 into master Nov 24, 2021
@trentm trentm deleted the trentm/release-3.25.0 branch November 24, 2021 17:43
@trentm
Copy link
Member Author

trentm commented Nov 24, 2021

[email protected] published
v3.25.0 tagged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants