-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drop no-longer-necessary half-disabling of instrumentations #2444
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
run module tests for mysql,pg,redis,ioredis |
@elastic/observablt-robots Would one of you be able to look into why the |
Paging @elastic/observablt-robots-on-call |
run module tests for redis,mysql |
When disableInstrumentations support was added in #353 it only
half-disabled these instrumentations, briefly mentioning "continuation
patches". I believe this was about user-land callback queue handling
that should no longer be necessary after run-context and #2430 work.
In #2498 it was discussed and decided that if listed in
disableInstrumentations
the agent should not touch the module at all.Checklist