Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop no-longer-necessary half-disabling of instrumentations #2444

Merged
merged 5 commits into from
Jan 31, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented Nov 16, 2021

When disableInstrumentations support was added in #353 it only
half-disabled these instrumentations, briefly mentioning "continuation
patches". I believe this was about user-land callback queue handling
that should no longer be necessary after run-context and #2430 work.

In #2498 it was discussed and decided that if listed in
disableInstrumentations the agent should not touch the module at all.

Checklist

  • Implement code: update from main, this is currently a bit out of date.
  • Test with TAV run.
  • Add CHANGELOG.asciidoc entry (an entry was added in the 3.26.0 release).

When disableInstrumentations support was added in #353 it only
half-disabled these instrumentations, briefly mentioning "continuation
patches". I believe this was about user-land callback queue handling
that should no longer be necessary after run-context and #2430 work.
@trentm trentm self-assigned this Nov 16, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Nov 16, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Nov 16, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Reason: null

  • Start Time: 2022-01-28T22:02:33.827+0000

  • Duration: 30 min 27 sec

  • Commit: b02ddde

Test stats 🧪

Test Results
Failed 0
Passed 243533
Skipped 0
Total 243533

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member Author

trentm commented Nov 16, 2021

run module tests for mysql,pg,redis,ioredis

@trentm
Copy link
Member Author

trentm commented Nov 17, 2021

@elastic/observablt-robots Would one of you be able to look into why the run module tests for mysql,pg,redis,ioredis comment above did not do anything? https://apm-ci.elastic.co/job/apm-agent-nodejs/job/apm-agent-nodejs-mbp/job/PR-2444/ only has the original build from when this PR was opened.

@cachedout
Copy link
Contributor

Would one of you be able to look into why the run module tests for mysql,pg,redis,ioredis comment above did not do anything?

Paging @elastic/observablt-robots-on-call

@v1v
Copy link
Member

v1v commented Nov 17, 2021

Would one of you be able to look into why the run module tests for mysql,pg,redis,ioredis comment above did not do anything?

IIUC, run module tests for mysql,pg,redis,ioredis matches ^run (module|benchmark) tests, but it's not, it should be ^run (module|benchmark) tests .*

image

Let me put a fix

@trentm
Copy link
Member Author

trentm commented Jan 28, 2022

run module tests for redis,mysql

@trentm trentm marked this pull request as ready for review January 28, 2022 22:02
@trentm trentm requested a review from astorm January 28, 2022 22:02
@trentm trentm merged commit dbaddc5 into main Jan 31, 2022
@trentm trentm deleted the trentm/y-u-half-enabled branch January 31, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants