-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prefer 'traceparent' header over 'elastic-apm-traceparent' header #2079
feat: prefer 'traceparent' header over 'elastic-apm-traceparent' header #2079
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving pending CI passing.
Just talking through the consequences of this out loud, there's a theoretical change in behavior if a user is setting both of these headers and we start preferring the W3C trace header over the old proprietary header.
However, this doesn't seem like anything that should cause a breaking change -- the behavior change will be better interoperability with the standards based header.
The only users who will see a degradation in their experience are folks who might have some services that add both headers, and other services that only add the old proprietary header. That seems like an edge case on an edge case (and they can always remain on an older agent), so I don't think we'll need a major version change for this change.
jenkins run the tests |
jenkins run the tests please |
…er (elastic#2079) When using traceparent info from headers of an incoming request, prefer the W3C "traceparent" header to Elastic's pre-W3C Trace Context spec header.
The w3c traceparent header is standardized and widely used enough now in Elastic tools that we should prefer it over the proprietary 'elastic-apm-traceparent' header.
See similar for Java, .NET.
Checklist