Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: docs for cloud provider configuration #1951

Merged
merged 2 commits into from
Jan 29, 2021
Merged

feat: docs for cloud provider configuration #1951

merged 2 commits into from
Jan 29, 2021

Conversation

astorm
Copy link
Contributor

@astorm astorm commented Jan 26, 2021 •
edited
Loading

Dependent on landing #1937 on landing, part of #1815 -- this PR contains the documentation for the new cloudProdiver configuration variable.

Checklist

  • Update documentation

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jan 26, 2021
@apmmachine
Copy link
Contributor

apmmachine commented Jan 26, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: astorm commented: jenkins run the tests please

    • Start Time: 2021-01-29T05:23:07.492+0000

  • Duration: 4 min 35 sec

  • Commit: a6c1ec5

trentm
trentm reviewed Jan 26, 2021
View reviewed changes
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astorm astorm requested review from trentm and bmorelli25 January 26, 2021 17:07
trentm
trentm previously approved these changes Jan 26, 2021
View reviewed changes
bmorelli25
bmorelli25 previously approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one very small nit

docs/configuration.asciidoc Outdated Show resolved Hide resolved
@astorm astorm mentioned this pull request Jan 26, 2021
Merged
3 tasks
@astorm astorm dismissed stale reviews from bmorelli25 and trentm via a6c1ec5 January 26, 2021 23:24
@astorm astorm requested a review from bmorelli25 January 26, 2021 23:24
@astorm
Copy link
Contributor Author

astorm commented Jan 29, 2021

jenkins run the tests please

@astorm astorm merged commit 0eb09de into master Jan 29, 2021
@astorm astorm deleted the astorm/config-docs branch January 29, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@trentm trentm trentm approved these changes

Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@astorm @apmmachine @trentm @bmorelli25