Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add changelog to PR checklist #1894

Merged
merged 2 commits into from
Nov 26, 2020
Merged

docs: add changelog to PR checklist #1894

merged 2 commits into from
Nov 26, 2020

Conversation

astorm
Copy link
Contributor

@astorm astorm commented Nov 25, 2020

Adds item to PR checklist reminding contributors to write a CHANGELOG.asciidoc entry.

Checklist

  • Implement code

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Nov 25, 2020
@astorm astorm requested a review from trentm November 25, 2020 23:07
@apmmachine
Copy link
Contributor

apmmachine commented Nov 25, 2020 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #1894 updated

  • Start Time: 2020-11-25T23:08:18.532+0000

  • Duration: 3 min 39 sec

trentm
trentm approved these changes Nov 26, 2020
View reviewed changes
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@astorm astorm merged commit 3bf8c9f into master Nov 26, 2020
@astorm astorm deleted the astorm/changlog-checklist branch November 26, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm approved these changes

Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astorm @apmmachine @trentm