Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add dynamic badge for central config #1715

Merged
merged 3 commits into from
Apr 13, 2020

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 commented Apr 10, 2020

What does this pull request do?

This PR adds the Dynamic badge to supported configurations. I defined "supported configurations" as options that are supported by the Apm app.

  • capture_body
  • transaction_max_spans
  • transaction_sample_rate

There are no discrepancies between the list above, and the list created in elastic/apm#213 (comment).

This PR also removed duplication of the precedence list.

Documentation preview

http://apm-agent-nodejs_760.docs-preview.app.elstc.co/diff

Screenshot

Screen Shot 2020-04-10 at 9 26 44 AM

Related issues

For elastic/apm#232
For https://github.com/elastic/observability-dev/issues/639

@bmorelli25 bmorelli25 requested a review from lreuven April 10, 2020 16:27
@bmorelli25 bmorelli25 self-assigned this Apr 10, 2020
Copy link

@lreuven lreuven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25 bmorelli25 merged commit c348d4f into elastic:master Apr 13, 2020
@bmorelli25 bmorelli25 deleted the add-dynamic-badge branch April 13, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants