test: ensure proper cleanup between config tests #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Qard
reviewed
Sep 23, 2019
| if (resettable) { | ||
| if (_asyncHook) _asyncHook.disable() | ||
| _asyncHook = asyncHook | ||
| } |
There was a problem hiding this comment.
Is there a reason not to just always do this? 🤔
There was a problem hiding this comment.
Good question... I did so in the first iteration but I wasn't 100% sure if there were any implications of keeping a reference to this object so it couldn't be garbage collected. This way it only kept it around during testing - but it's probably irrelevant 🤷♂
There was a problem hiding this comment.
Fair. Approved anyway just to get the fix in. I can clean it up later. 🤔
Qard
approved these changes
Sep 23, 2019
|
jenkins run the tests please |
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Sep 24, 2019
watson
added a commit
to watson/apm-agent-nodejs
that referenced
this pull request
Sep 24, 2019
watson
added a commit
that referenced
this pull request
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was all the code that came out of trying to solve a weird CI related issue in #1114.
I thought it was best to submit it as a separate PR in case we want to backport it.