-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more fine grained disabling of http module features #434
Labels
Comments
Suggested solution: |
If this turns out to be complicated, we can move it to 3.0.0. |
Qard
pushed a commit
to Qard/apm-agent-nodejs
that referenced
this issue
Oct 19, 2018
3 tasks
Qard
pushed a commit
to Qard/apm-agent-nodejs
that referenced
this issue
Oct 19, 2018
Qard
pushed a commit
to Qard/apm-agent-nodejs
that referenced
this issue
Oct 29, 2018
Qard
pushed a commit
to Qard/apm-agent-nodejs
that referenced
this issue
Oct 31, 2018
Qard
pushed a commit
to Qard/apm-agent-nodejs
that referenced
this issue
Nov 6, 2018
alvarolobato
added
breaking change
enhancement
[zube]: Backlog
and removed
breaking change
[zube]: In Review
labels
Dec 4, 2018
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's not possible to switch off the automatic creation of HTTP request transactions when an incoming HTTP request is detected without also switching off tracing of outgoing HTTP requests. This is because they are both controlled by this cone setting:
disableInstrumentations: ['http']
.It would be very useful - both to users, but especially also during debugging - if it was possible to control the two features separately.
Considerations
Today there's a one to one relationship between npm package names and the content of the
disableInstrumentations
config option. I don't think it would be a good idea to introduce an exception just to solve this case.As an alternative we could consider if the config option instead should focus on span types, so instead of disabling
pg
, you would disabledb.postgresql
(the full type isdb.postgresql.query
, but I guess we can just match against the start of the string, which also means that we could writedb
to disable all db spans).There's pros and cons to this, so it should be considered thoroughly.
The text was updated successfully, but these errors were encountered: