Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span Compression: Implement Span Buffering Behavior #2600

Closed
astorm opened this issue Mar 7, 2022 · 0 comments
Closed

Span Compression: Implement Span Buffering Behavior #2600

astorm opened this issue Mar 7, 2022 · 0 comments
Assignees
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@astorm
Copy link
Contributor

astorm commented Mar 7, 2022

This PR represents the work needed to implement the span buffering behavior of the Compressing spans work. We will need to

  • Implement the configuration gated span end buffering behavior described in the spec
  • Implement the tryToCompress method fully
  • Implement a preliminary isCompressionEligible method that, contrary to spec, uses the outcome AND a hard coded list of span types to determine if it's compressible

At the end of this work we will have an agent that compresses spans but is not 100% spec compliant.

@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Mar 7, 2022
@astorm astorm self-assigned this Mar 7, 2022
@astorm astorm mentioned this issue Mar 29, 2022
5 tasks
astorm added a commit that referenced this issue Apr 11, 2022
* feat: Implement Span Compression Algorithm 

#2600
@astorm astorm closed this as completed Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

No branches or pull requests

1 participant