fix: ESM hooking with Node.js v18.19.0

[email protected] fixes an issue with double-importing with node 18.19.0 (due to a backport of ESM loading being done off main thread). Fixes: #3784
elastic · Dec 11, 2023 · 40490e8 · 40490e8
1 parent a9dc49c
commit 40490e8
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 11 deletions.
diff --git a/.ci/tav.json b/.ci/tav.json
@@ -1,6 +1,5 @@
 {
-  "// versions": "Skip >=18.19.0 until IITM double-import issue is resolved.",
-  "versions": [ "21", "20", "18.18.2", "16", "14" ],
+  "versions": [ "21", "20", "18", "16", "14" ],
   "// modules": [
     "List of instrumented modules with the minimum Node major version supported.",
     "minMajorVersion for each module should be kept in sync with .tav.yml"

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -130,7 +130,7 @@ jobs:
           - '21.0'
           - '20'
           - '20.0'
-          - '18.18.2' # Skip >=18.19.0 until IITM double-import issue is resolved.
+          - '18'
           - '18.0'
           - '16'
           - '16.0'

diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc
@@ -33,6 +33,23 @@ Notes:
 
 See the <<upgrade-to-v4>> guide.
 
+==== Unreleased
+
+[float]
+===== Breaking changes
+
+[float]
+===== Features
+
+[float]
+===== Bug fixes
+
+* Fix <<esm>> with Node v18.19.0 (and later versions of Node v18.x).
+  ({issues}3784[#3784])
+
+[float]
+===== Chores
+
 
 [[release-notes-4.3.0]]
 ==== 4.3.0 - 2023/12/05

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -105,7 +105,7 @@
     "fast-safe-stringify": "^2.0.7",
     "fast-stream-to-buffer": "^1.0.0",
     "http-headers": "^3.0.2",
-    "import-in-the-middle": "1.5.0",
+    "import-in-the-middle": "^1.6.0",
     "json-bigint": "^1.0.0",
     "lru-cache": "^10.0.1",
     "measured-reporting": "^1.51.1",
-Original file line number
+Diff line change
@@ Expand Up / @@ -130,7 +130,7 @@ jobs: @@
               - '21.0'
               - '20'
               - '20.0'
-              - '18.18.2' # Skip >=18.19.0 until IITM double-import issue is resolved.
+              - '18'
               - '18.0'
               - '16'
               - '16.0'
@@ Expand Down @@