Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add database link to span context(#732) #735

Merged
merged 3 commits into from
Jul 22, 2019
Merged

Add database link to span context(#732) #735

merged 3 commits into from
Jul 22, 2019

Conversation

wolframhaussig
Copy link
Contributor

closes #732

Checklist

  • Implement code
  • Add tests

@felixbarny felixbarny requested a review from eyalkoren July 19, 2019 13:58
eyalkoren
eyalkoren reviewed Jul 21, 2019
View reviewed changes
Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @wolframhaussig 😊
One tiny comment.

apm-agent-core/src/main/java/co/elastic/apm/agent/report/serialize/DslJsonSerializer.java Outdated Show resolved Hide resolved
eyalkoren
eyalkoren approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @wolframhaussig !

@eyalkoren
Copy link
Contributor

@wolframhaussig please merge with master and push. There is an error in master currently that won't let us run the tests.

@felixbarny
Copy link
Member

run the tests

@eyalkoren eyalkoren merged commit 63628bf into elastic:master Jul 22, 2019
@wolframhaussig wolframhaussig deleted the 732-Add-database-link-to-span-context branch July 30, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalkoren eyalkoren eyalkoren approved these changes

@felixbarny felixbarny felixbarny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add database link to span context
4 participants
@wolframhaussig @eyalkoren @felixbarny @lreuven