Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reflection rather than MethodHandles #487

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented Feb 11, 2019

This is a workaround for a bug in the C2 compiler in Java 7 which leads to a segfault
closes #458

This is a workaround for a bug in the C2 compiler in Java 7 which leads to a segfault
closes elastic#458
@felixbarny
Copy link
Member Author

Snapshot for these changes: elastic-apm-agent-1.3.1-SNAPSHOT.jar.zip

@codecov-io
Copy link

Codecov Report

Merging #487 into master will not change coverage.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #487   +/-   ##
=========================================
  Coverage     64.32%   64.32%           
  Complexity       68       68           
=========================================
  Files           164      164           
  Lines          6197     6197           
  Branches        716      716           
=========================================
  Hits           3986     3986           
  Misses         1965     1965           
  Partials        246      246
Impacted Files Coverage Δ Complexity Δ
...astic/apm/agent/metrics/builtin/SystemMetrics.java 71.05% <75%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85960af...91137e4. Read the comment docs.

@felixbarny felixbarny merged commit 90b64b3 into elastic:master Feb 12, 2019
@felixbarny felixbarny deleted the metrics-reflection branch February 12, 2019 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JVM crash with Java 7 + Agent 1.3.0
3 participants