Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush reporter on shutdown #397

Merged
merged 1 commit into from
Jan 7, 2019

Conversation

felixbarny
Copy link
Member

@codecov-io
Copy link

Codecov Report

Merging #397 into master will increase coverage by 0.05%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #397      +/-   ##
============================================
+ Coverage     72.03%   72.08%   +0.05%     
+ Complexity     1315     1269      -46     
============================================
  Files           141      140       -1     
  Lines          5142     4879     -263     
  Branches        532      497      -35     
============================================
- Hits           3704     3517     -187     
+ Misses         1212     1140      -72     
+ Partials        226      222       -4
Impacted Files Coverage Δ Complexity Δ
...pm/agent/report/IntakeV2ReportingEventHandler.java 74.35% <100%> (+1.2%) 33 <0> (+3) ⬆️
...va/co/elastic/apm/agent/report/ReportingEvent.java 86.66% <100%> (+0.95%) 11 <1> (+1) ⬆️
...co/elastic/apm/agent/report/ApmServerReporter.java 59.4% <77.77%> (+1.34%) 13 <2> (ø) ⬇️
.../agent/plugin/api/AbstractSpanInstrumentation.java 53.19% <0%> (-2.06%) 3% <0%> (-4%)
...java/co/elastic/apm/agent/bci/ElasticApmAgent.java 72.18% <0%> (-0.5%) 19% <0%> (-2%)
...bci/bytebuddy/FailSafeDeclaredMethodsCompiler.java
...astic/apm/agent/impl/transaction/TraceContext.java 92.21% <0%> (+0.54%) 56% <0%> (-38%) ⬇️
...agent/plugin/api/ElasticApmApiInstrumentation.java 52% <0%> (+5.57%) 3% <0%> (-2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 863822f...f98d93a. Read the comment docs.

@felixbarny felixbarny merged commit 64a6c21 into elastic:master Jan 7, 2019
@felixbarny felixbarny deleted the flush-on-shutdown branch January 7, 2019 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants