Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildkite: add permissions to observablt-robots-automation #3420

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

v1v
Copy link
Member

@v1v v1v commented Nov 8, 2023

What does this PR do?

Use a machine account which it's member of https://github.com/orgs/elastic/teams/observablt-robots-automation

Checklist

  • This is an enhancement of existing features, or a new feature in existing plugins
    • I have updated CHANGELOG.asciidoc
    • I have added tests that prove my fix is effective or that my feature works
    • Added an API method or config option? Document in which version this will be introduced
    • I have made corresponding changes to the documentation
  • This is a bugfix
  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident.
  • This is something else

@v1v v1v requested review from amannocci, reakaleek and a team November 8, 2023 21:29
@v1v v1v self-assigned this Nov 8, 2023
reakaleek
reakaleek previously approved these changes Nov 8, 2023
catalog-info.yaml Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
@SylvainJuge
Copy link
Member

Is there any reason to not always have BUILD_AND_READ for observablt-robots-automation ?

From what I understand observablt-robots-automation is only used for automation and machine jobs, and I don't think we need to allow managing the jobs themselves, which I would have expected to be a human-only responsibility.

catalog-info.yaml Outdated Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
catalog-info.yaml Outdated Show resolved Hide resolved
@v1v
Copy link
Member Author

v1v commented Nov 9, 2023

BUILD_AND_READ is now the default behaviour

@v1v v1v merged commit 2c82469 into elastic:main Nov 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants