-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace binary propagation with UTF8 encoded text propagation #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation logic for elastic-apm-traceparent to kafka header manager
…cii byte arrays without allocations
jackshirazi
reviewed
Sep 4, 2023
apm-agent-core/src/main/java/co/elastic/apm/agent/impl/transaction/TraceContext.java
Show resolved
Hide resolved
jackshirazi
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OMG thank you, this leaves it so much cleaner! The only thing I suggest is to move the deleted binary header structure comment over to the KafkaRecordHeaderAccessor class, since we're still supporting that header
jackshirazi
approved these changes
Sep 6, 2023
# Conflicts: # CHANGELOG.asciidoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #3017.
This change has been tested manually for sending / receiving kafka interoperability with both older elastic APM agents and the opentelemetry agent.
Checklist
Added an API method or config option? Document in which version this will be introducedI have made corresponding changes to the documentation