Moves ServiceInfo to tracer module and reduce dependency exposure to core module of plugins. #3272
Conversation
github-actions
bot
added
agent-java
community
|
👋 @raphw Thanks a lot for your contribution! It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it. Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it. |
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateFor security reasons, Mergify can't update this pull request. Try updating locally. |
|
|
raphw
force-pushed
the
service-info-extraction
branch
from
b26df56 to
ac78bc8
Compare
raphw
force-pushed
the
service-info-extraction
branch
from
ac78bc8 to
e81f082
Compare
|
run elasticsearch-ci/docs |
There was a problem hiding this comment.
Looks good, the autodiscovery is now nicely separated.
ExternalPluginOTelIT is failing, what I cannot quite explain by looking at the change set. I also struggle to debug the test, but I am looking into it. If you have any pointers, it's appreciated.
Did you find out the reason for this? Or did the issue fix itself by rebasing / merging this PR onto the current main?
|
It disappeared when I rebased, yes. |
…core module of plugins. (elastic#3272) * Move ServiceInfo to tracer-api within custom tracer submodule. * Restore package structure and split test for ServiceInfo.
Introduces a subinterface
ServiceTracerwhich indicates support for registering and readingServiceInfoinformation to enrich trace information.