Move global tracer and substitute agent-core types with API types where this is trivially possible.

[raphw]

This change is mainly generated by IDEA code substitution, with minor adjustments. By using API types, the dependency on implementation is reduced and the required API surface becomes more visible. This change is in preparation of removing the core module as a dependency of the internal plugins.

• This is something else
  • I have updated CHANGELOG.asciidoc

[github-actions]

👋 @raphw Thanks a lot for your contribution!

It may take some time before we review a PR, so even if you don’t see activity for some time, it does not mean that we have forgotten about it.

Every once in a while we go through a process of prioritization, after which we are focussing on the tasks that were planned for the upcoming milestone. The prioritization status is typically reflected through the PR labels. It could be pending triage, a candidate for a future milestone, or have a target milestone set to it.

[raphw]

This is mostly auto-generated. I do however wonder about one difference, and that is the change here: main...raphw:apm-agent-java:reduce-api-exposure#diff-732acc761e4310277786f5059749ac54e3f0dcfa17d8976ca3892fa7fb7d5c52L154

This particular use of TraceContext was previously a unique application of this API. Is it the same as using addLink (addSpanLink) to which I normalized this? It leads to the same asChildOf call, but also adds a link entry.

[apmmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-03-24T23:23:53.810+0000

• Duration: 14 min 13 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• run benchmark tests : Run the benchmark tests.

• run jdk compatibility tests : Run the JDK Compatibility tests.

• run integration tests : Run the Agent Integration tests.

• run end-to-end tests : Run the APM-ITs.

• run windows tests : Build & tests on windows.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[JonasKunz]

Approval to allow running on CI, thorough review will follow.

[JonasKunz]

Just a few minor comments.
In addition I think the tests are currently failing and still need some attention.

[raphw]

Tests should be fixed by now. Mainly missing mock configurations to reflect require calls properly. And of course JmsInstrumentationIT needed an adjustment with regards to the span link change.

[JonasKunz]

I think we are good to merge!
Side Note for the next PR: Would be great if you could use merge instead of force-push. This allows us to use the "Review changes since last review" feature from GH when doing review iterations.

[raphw]

Will do, I rebased to main, in hope that a mysterious test error would disappear by it, that's what the force push was about.

[JonasKunz]

run elasticsearch-ci/docs