Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readded ldap plugin, added instrumentation module opening support #2977

Merged
merged 9 commits into from
Jan 26, 2023
Merged

Readded ldap plugin, added instrumentation module opening support #2977

merged 9 commits into from
Jan 26, 2023

Conversation

JonasKunz
Copy link
Contributor

@JonasKunz JonasKunz commented Jan 19, 2023 •
edited
Loading

What does this PR do?

Adds back the LDAP plugin which was removed via #2431 .
The open issues were solved by adding the capabilities for instrumentation plugins to open modules via instrumentation.

Closes #2966.

Checklist

  • This is a new plugin
    • I have updated CHANGELOG.asciidoc
    • My code follows the style guidelines of this project
    • I have made corresponding changes to the documentation
    • I have added tests that prove my fix is effective or that my feature works
    • New and existing unit tests pass locally with my changes
    • I have updated supported-technologies.asciidoc
    • Added an API method or config option? Document in which version this will be introduced
    • Added an instrumentation plugin? Describe how you made sure that old, non-supported versions are not instrumented by accident. Ldap implementation is ancient

@apmmachine
Copy link
Contributor

apmmachine commented Jan 19, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview previewSnapshots

Expand to view the summary

Build stats

  • Start Time: 2023-01-26T11:36:13.319+0000

  • Duration: 60 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 3440
Skipped 43
Total 3483

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark tests.

  • run jdk compatibility tests : Run the JDK Compatibility tests.

  • run integration tests : Run the Agent Integration tests.

  • run end-to-end tests : Run the APM-ITs.

  • run windows tests : Build & tests on windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@JonasKunz JonasKunz marked this pull request as ready for review January 19, 2023 15:57
@github-actions
Copy link

/test

@jamesdowell2022
Copy link

Forwarded to the customer asking to test and feedback. Thanks so much for the incredible turnaround time!!

@AlexanderWert AlexanderWert mentioned this pull request Jan 23, 2023
Merged
AlexanderWert added a commit to elastic/kibana that referenced this pull request Jan 24, 2023
@AlexanderWert
Added LDAP icon to span icons (#149330)
4525608 
## Summary

With elastic/apm-agent-java#2977 the Java agent
adds instrumentation for LDAP spans.
Added span icon for LDAP spans:

<img width="590" alt="image"
src="https://user-images.githubusercontent.com/866830/214064572-66be6de5-d3de-4ea0-9e1f-e59b7f611ed5.png">
@elastic elastic deleted a comment from jamesdowell2022 Jan 24, 2023
@JonasKunz JonasKunz requested a review from eyalkoren January 24, 2023 12:57
@JonasKunz
Copy link
Contributor Author

@eyalkoren This PR should be ready to review now, we got positive feedback from a customer who tested this PR snapshot.

eyalkoren
eyalkoren approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@eyalkoren eyalkoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely brilliant! 👋
Including code, comments and test.
I added some comments, mostly about readability or reuse of code, but all minor enough to approve regardless. Feel free to decide which to use and which to ignore,
Well done!

@JonasKunz JonasKunz enabled auto-merge (squash) January 26, 2023 10:21
@JonasKunz JonasKunz merged commit c4a9dc6 into elastic:main Jan 26, 2023
@JonasKunz JonasKunz deleted the ldap-module-support branch January 26, 2023 16:08
@SylvainJuge SylvainJuge mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalkoren eyalkoren eyalkoren approved these changes

Assignees
No one assigned
Labels
agent-java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Instrumentation of LDAP requests
4 participants
@JonasKunz @apmmachine @jamesdowell2022 @eyalkoren