Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require separate advice class #2101

Merged
merged 8 commits into from
Sep 7, 2021
Merged

Require separate advice class #2101

merged 8 commits into from
Sep 7, 2021

Conversation

felixbarny
Copy link
Member

@felixbarny felixbarny commented Sep 1, 2021 •
edited by zube bot
Loading

What does this PR do?

Avoids class loading issues when the advice refers to library classes.

This allows to validate the advice class when the instrumentations get initialized
as opposed to on indy bootstrap.
That caches more errors and fails faster.

relates to #1337

@felixbarny
Require advice to be declared in a separate class
52d0ff3 
Avoids class loading issues when the advice refers to library classes.

This allows to validate the advice class when the instrumentations get initialized
as opposed to on indy bootstrap.
That caches more errors and fails faster.
@felixbarny
Remove @VisibleForAdvice
55bbb78
@felixbarny
Default advice class name
439aabe 
getClass().getName() + "$AdviceClass"
@apmmachine
Copy link
Contributor

apmmachine commented Sep 1, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-07T08:12:38.099+0000

  • Duration: 56 min 54 sec

  • Commit: 1ac5ecd

Test stats 🧪

Test Results
Failed 0
Passed 2394
Skipped 19
Total 2413

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2394
Skipped 19
Total 2413

SylvainJuge
SylvainJuge approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@SylvainJuge SylvainJuge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good idea to use AdviceClass as a generic default to avoid having to properly find dozen of relevant class names.

@felixbarny felixbarny mentioned this pull request Sep 6, 2021
Merged
@felixbarny
Copy link
Member Author

felixbarny commented Sep 6, 2021 •
edited
Loading

@felixbarny felixbarny merged commit 48d8d81 into elastic:master Sep 7, 2021
@felixbarny felixbarny deleted the require-separate-advice-class branch September 7, 2021 09:30
@eyalkoren eyalkoren mentioned this pull request Sep 13, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainJuge SylvainJuge SylvainJuge approved these changes

Assignees
No one assigned
Labels
agent-java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixbarny @apmmachine @SylvainJuge