Migrate Apache HttpClient plugin to indy plugin #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 tasks
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
SylvainJuge
approved these changes
Aug 31, 2020
| @@ -448,7 +448,7 @@ private static void validateAdvice(Class<?> adviceClass) { | |||
| } | |||
| for (MethodDescription.InDefinedShape exitAdvice : typeDescription.getDeclaredMethods().filter(isStatic().and(isAnnotatedWith(Advice.OnMethodExit.class)))) { | |||
| validateAdviceReturnAndParameterTypes(exitAdvice); | |||
| if (exitAdvice.getReturnType().getTypeName().startsWith("co.elastic.apm")) { | |||
| if (exitAdvice.getReturnType().asRawType().getTypeName().startsWith("co.elastic.apm")) { | |||
There was a problem hiding this comment.
[question] why do we have to use raw type here ? maybe add a small comment.
There was a problem hiding this comment.
This is to avoid that the type gets resolved (leading to exceptions). That part of the code will change once we merge in the changes you made for WebFlux. So adding a comment would make merging trickier.
There was a problem hiding this comment.
Thank you for taking care of making other's PRs easier to merge !!
...ugin/src/main/java/co/elastic/apm/agent/httpclient/ApacheHttpAsyncClientInstrumentation.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
does what it says on the tin
relates to #1337