Review fixes

elastic · Dec 6, 2023 · eb6d623 · eb6d623
1 parent 430be21
commit eb6d623
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...-sdk/src/main/java/co/elastic/apm/agent/embeddedotel/proxy/ProxyLongHistogramBuilder.java b/...-sdk/src/main/java/co/elastic/apm/agent/embeddedotel/proxy/ProxyLongHistogramBuilder.java
@@ -31,7 +31,7 @@ public class ProxyLongHistogramBuilder {
 
     public ProxyLongHistogramBuilder(LongHistogramBuilder delegate) {
         this.delegate = delegate;
-        //apply default bucket boundaries
+        //apply default bucket boundaries, they are guaranteed to be ordered
         List<Double> boundaries = GlobalTracer.get().getConfig(MetricsConfiguration.class).getCustomMetricsHistogramBoundaries();
         delegate.setExplicitBucketBoundariesAdvice(convertToLongBoundaries(boundaries));
     }

diff --git a/...k-plugin/src/main/java/co/elastic/apm/agent/otelmetricsdk/ElasticOtelMetricsExporter.java b/...k-plugin/src/main/java/co/elastic/apm/agent/otelmetricsdk/ElasticOtelMetricsExporter.java
@@ -121,7 +121,7 @@ private static boolean checkOtelApiSupportsHistogramBucketAdvice() {
         try {
             DoubleHistogramBuilder.class.getMethod("setExplicitBucketBoundariesAdvice", List.class);
             return true;
-        } catch (NoSuchMethodException e) {
+        } catch (NoSuchMethodException | SecurityException e) {
             return false;
         }
     }