Concurrency fixes #997
Merged
Concurrency fixes #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add synchronisation to requestTracer. Sayeth the httptrace docs: > Functions may be called concurrently from different goroutines and some may be called after the request has completed or failed. There's also a minor enhancement here to set the Connect span outcome to "failure" if an error occurred.
Fix a deadlock that can occur when concurrently ending a parent and child span, due to the parent waiting for the child to release the transaction lock, and the child waiting to lock the parent. Locks are now taken in a consistent order.
Closed
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
stuartnelson3
approved these changes
Aug 5, 2021
blessedvictim
pushed a commit
to blessedvictim/apm-agent-go
that referenced
this pull request
Aug 10, 2021
* module/apmhttp: add locking to httptrace handlers Add synchronisation to requestTracer. Sayeth the httptrace docs: > Functions may be called concurrently from different goroutines and some may be called after the request has completed or failed. There's also a minor enhancement here to set the Connect span outcome to "failure" if an error occurred. * apm: fix deadlock in breakdown metrics calculation Fix a deadlock that can occur when concurrently ending a parent and child span, due to the parent waiting for the child to release the transaction lock, and the child waiting to lock the parent. Locks are now taken in a consistent order.
jsoriano
added a commit
to elastic/package-registry
that referenced
this pull request
Oct 19, 2021
It includes a fix elastic/apm-agent-go#997 for some concurrency bugs. Gorilla is indirectly also updated to 1.8.0, but this only includes a fix in a feature we don't use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a deadlock that can occur when concurrently ending a parent and child span, due to the parent waiting for the child to release the transaction lock, and the child waiting to lock the parent. Locks are now taken in a consistent order.
Add synchronisation to the httptrace handlers implemented by the
module/apmhttp.WithClientTraceoption. Sayeth the httptrace docs:There's a minor enhancement to the handlers to set the Connect span outcome to "failure" if an error occurred.
Fixes #994