Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update golang.org/x/sys. #689

Merged
merged 1 commit into from
Dec 7, 2019
Merged

Update golang.org/x/sys. #689

merged 1 commit into from
Dec 7, 2019

Conversation

ldez
Copy link
Contributor

@ldez ldez commented Dec 6, 2019

Because of changes in golang.org/x/sys already reported on elastic/go-sysinfo.

Those changes impact elastic/go-sysinfo and golang.org/x/crypto

Related to:

@codecov-io
Copy link

codecov-io commented Dec 6, 2019

Codecov Report

Merging #689 into master will decrease coverage by 0.46%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
- Coverage   88.18%   87.72%   -0.47%     
==========================================
  Files         125      125              
  Lines        8270     7893     -377     
==========================================
- Hits         7293     6924     -369     
- Misses        851      861      +10     
+ Partials      126      108      -18
Impacted Files Coverage Δ
config.go 82.54% <0%> (-7%) ⬇️
tracer.go 91.15% <0%> (-1.09%) ⬇️
breakdown.go 95.89% <0%> (-0.63%) ⬇️
model/marshal_fastjson.go 75.7% <0%> (-0.16%) ⬇️
transaction.go 96.61% <0%> (+1.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b5263a...4113dff. Read the comment docs.

@axw
Copy link
Member

axw commented Dec 7, 2019

Thanks @ldez!

@axw
Copy link
Member

axw commented Dec 7, 2019

jenkins run the tests please

@axw
Copy link
Member

axw commented Dec 7, 2019

jenkins run the tests please

@axw axw merged commit 5d9e8d1 into elastic:master Dec 7, 2019
@ldez ldez deleted the fix/xsys branch December 7, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants