Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ELASTIC_APM_CAPTURE_HEADERS #418

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Conversation

axw
Copy link
Member

@axw axw commented Jan 9, 2019

Introduce the ELASTIC_APM_CAPTURE_HEADERS config,
which controls whether or not HTTP headers will be captured.
Defaults to true.

Closes #390

Introduce the ELASTIC_APM_CAPTURE_HEADERS config,
which controls whether or not HTTP headers will
be captured. Defaults to true.
@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

Merging #418 into master will increase coverage by 3.43%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   80.55%   83.99%   +3.43%     
==========================================
  Files         102      102              
  Lines        6213     6234      +21     
==========================================
+ Hits         5005     5236     +231     
+ Misses        929      925       -4     
+ Partials      279       73     -206
Impacted Files Coverage Δ
env.go 87.35% <100%> (+6.17%) ⬆️
context.go 94.23% <100%> (+2.15%) ⬆️
error.go 78.8% <100%> (+4.77%) ⬆️
transaction.go 95.37% <100%> (+4.89%) ⬆️
tracer.go 88.61% <88.88%> (+3.38%) ⬆️
modelwriter.go 95.04% <0%> (+0.82%) ⬆️
internal/radix/radix.go 39.92% <0%> (+0.92%) ⬆️
utils.go 80.68% <0%> (+1.13%) ⬆️
internal/sqlscanner/scanner.go 96.82% <0%> (+1.58%) ⬆️
metrics.go 91.66% <0%> (+1.66%) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24f8f6c...dd555c1. Read the comment docs.

@axw axw merged commit 1107fe2 into elastic:master Jan 9, 2019
@axw axw deleted the capture-headers branch January 9, 2019 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants