Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apm: add support for github.com/pkg/errors@master #409

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

axw
Copy link
Member

@axw axw commented Jan 7, 2019

github.com/pkg/errors has broken backwards compatibility
on master, which will become 0.9.0. Until we can get rid
of support for the older version (which, undoubtedly, many
people are using), we will support both by using reflection.

Bump version to v1.1.3.

Fixes #408

axw added 2 commits January 7, 2019 10:13
github.com/pkg/errors has broken backwards compatibility
on master, which will become 0.9.0. Until we can get rid
of support for the older version (which, undoubtedly, many
people are using), we will support both by using reflection.

Fixes elastic#408
@codecov-io
Copy link

codecov-io commented Jan 7, 2019

Codecov Report

Merging #409 into master will decrease coverage by 0.43%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #409      +/-   ##
=========================================
- Coverage   84.33%   83.9%   -0.44%     
=========================================
  Files         103     102       -1     
  Lines        6467    6132     -335     
=========================================
- Hits         5454    5145     -309     
+ Misses        945     917      -28     
- Partials       68      70       +2
Impacted Files Coverage Δ
error.go 75.97% <60%> (-6.38%) ⬇️
stacktrace/context.go 77.5% <0%> (-2.5%) ⬇️
module/apmsql/pq/parser.go 78.78% <0%> (-2.03%) ⬇️
stacktrace/library.go 100% <0%> (ø) ⬆️
gocontext.go 100% <0%> (ø) ⬆️
module/apmot/internal/harness/api_checkers.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f96ceb...cff2898. Read the comment docs.

@axw axw merged commit 2773fa2 into elastic:master Jan 7, 2019
@axw axw deleted the errors-frame branch January 7, 2019 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot convert frame to type uintptr
2 participants