Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module/apmlogrus: introduce logrus integration #381

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Conversation

axw
Copy link
Member

@axw axw commented Dec 7, 2018

Introduce a new package which provides integrations for logrus:

  • Hook, which implements logrus.Hook, to reports error messages.
  • TraceContext, which extracts logrus.Fields from transactions
    and spans in the provided context.

TODO:

  • update supported tech docs
  • write docs on how to integrate with logrus

Closes #355

Introduce a new package which provides integrations for logrus:

 - Hook, which implements logrus.Hook, to reports error messages.
 - TraceContext, which extracts logrus.Fields from transactions
   and spans in the provided context.
@codecov-io
Copy link

codecov-io commented Dec 7, 2018

Codecov Report

Merging #381 into master will increase coverage by 3.42%.
The diff coverage is 84.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   80.49%   83.92%   +3.42%     
==========================================
  Files          98      101       +3     
  Lines        6018     6089      +71     
==========================================
+ Hits         4844     5110     +266     
- Misses        905      913       +8     
+ Partials      269       66     -203
Impacted Files Coverage Δ
tracecontext.go 100% <100%> (ø) ⬆️
tracer.go 88.58% <100%> (+3.41%) ⬆️
module/apmlogrus/fields.go 100% <100%> (ø)
module/apmlogrus/hook.go 76.19% <76.19%> (ø)
apmtest/discard.go 83.33% <83.33%> (ø)
modelwriter.go 94.95% <0%> (+0.84%) ⬆️
internal/radix/radix.go 39.92% <0%> (+0.92%) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccc9f2b...7c2f024. Read the comment docs.

@axw axw merged commit 11ff748 into elastic:master Dec 7, 2018
@axw axw deleted the logrus branch December 7, 2018 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants