Report spans independently of transactions #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Transaction.Spans. Spans now stand on their own. Also, drop the payload structures, which are no longer used with v2.
Spans are no longer embedded in transactions, and they are reported independently. A span may outlive a transaction, so there is no truncation, and we must take care never to store references to transactions in a span.
Another faulty assumption. We can't expect anything about the contents of the initial request, as the flush could come before any individual transaction is picked up.
When closing the tracer, make sure the iochan.Reader is closed first. This fixes a race in TestTracerRequestSize, which ignores the ctx's cancellation.
Codecov Report
@@ Coverage Diff @@
## v2 #188 +/- ##
==========================================
- Coverage 80.25% 80.17% -0.08%
==========================================
Files 87 87
Lines 5166 5110 -56
==========================================
- Hits 4146 4097 -49
- Misses 815 817 +2
+ Partials 205 196 -9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spans are no longer embedded in transactions,
and they are reported independently. A span
may outlive a transaction, so there is no
truncation, and we must take care never to
store references to transactions in a span.