[Bugfix] apm.DefaultTracer misbehaves when transport configuration is invalid #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamsharma7867
changed the title
…rt the case where invalid tracer config
dmathieu
reviewed
Apr 29, 2024
…of invalid configuration
dmathieu
reviewed
May 2, 2024
dmathieu
reviewed
May 3, 2024
tracer_test.go
Outdated
| @@ -597,17 +597,11 @@ func TestTracerDefaultTransport(t *testing.T) { | |||
| require.Error(t, err) | |||
| assert.EqualError(t, err, "failed to parse ELASTIC_APM_SERVER_TIMEOUT: invalid duration never") | |||
|
|
|||
| // Implicitly created Tracers will have a discard tracer. | |||
|
|
|||
There was a problem hiding this comment.
I'd recommend running the go linter locally. This additional new line is not necessary.
There was a problem hiding this comment.
You will also want to run the tests locally, as they currently are failing.
There was a problem hiding this comment.
hi @dmathieu, I did run test before raising the PR and again. As per the code DefaultTracer is being used in three places and I ran the UT's and they are working fine
There was a problem hiding this comment.
make test did fail consistently in CI, as well as locally here.
This was because the tracecontext example relies on a discarded tracer.
But now, it had an inactive one (though this was due to previous tests). I've fixed it.
kruskall
approved these changes
May 6, 2024
|
run docs-build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix amp.DefaultTracer misbehaves if transport specific configuration invalid, Incase of invalid config It will make transport inactive instead passing DiscardTransport