-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apmotel: follow APM OTel spec and prefer delta temporality #1437
Conversation
d75abf1
to
3ad3c80
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This brings us closer to the spec https://github.com/elastic/apm/blob/main/specs/agents/metrics-otel.md#aggregation-temporality
There's also this:
For all instrument types with delta temporality, agents MUST filter out zero values before exporting. E.g. if a counter does not change since the last export, it must not be exported.
If you have time, could you take a stab at that too? Otherwise could you please open an issue?
Taken a stab at it, see if it makes sense to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the panic removed. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the panic removed. Thanks!
Co-authored-by: Andrew Wilkins <[email protected]>
…t-go into otel-delta-temporality
Make apmotel follow apm otel spec: https://github.com/elastic/apm/blob/main/specs/agents/metrics-otel.md#aggregation-temporality
Closes #1436