Rely on the latest stable otel, not rc2 #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those variables aren't necessary anymore. And GOPROXY is preventing upgrading modules, since they can't be cached
simitt
approved these changes
Apr 27, 2023
dmathieu
commented
Apr 27, 2023
| @@ -143,8 +143,6 @@ func updateModule(dir string, gomod *GoMod, modules map[string]*GoMod) error { | |||
| args = append(args, "-go", *goVersionFlag) | |||
| } | |||
| cmd := exec.Command("go", args...) | |||
| cmd.Env = append(os.Environ(), "GO111MODULE=on") | |||
| cmd.Env = append(cmd.Env, "GOPROXY=http://proxy.invalid", "GOSUMDB=sum.golang.org https://sum.golang.org") | |||
There was a problem hiding this comment.
I had to remove this, seemingly because of module version changes, which causes a download (before, the modules were in cache).
I'm not sure what the reasoning for GOPROXY is, and will merge to move forward. But I'm happy to rethink this also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I first hoped we could rely on the RC2 for the stable metrics API of otel, which provides more stability.
But the otelhttp instrumentation still relies on 0.37.0. So we need to use that version.