Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.4.0 #1417

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Release 2.4.0 #1417

merged 6 commits into from
Apr 27, 2023

Conversation

dmathieu
Copy link
Member

This cuts the release for 2.4.0, which adds support for OpenTelemetry.
See the diff: v2.3.0...main

@@ -84,7 +84,6 @@ For example, APM Server version `7.15.0` corresponds with the Go APM Agent versi

1. Update `version.go` and `internal/apmversion/version.go`, and then run `make update-modules`
2. Update [`CHANGELOG.asciidoc`](changelog.asciidoc), by adding a new version heading (`==== 1.x.x - yyyy/MM/dd`) and changing the base tag of the Unreleased comparison URL
3. For major and minor releases, update the EOL table in [`upgrading.asciidoc`](docs/upgrading.asciidoc).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #1335, there is no EOL table anymore.

@dmathieu dmathieu requested a review from a team April 26, 2023 09:24
@lahsivjar
Copy link
Contributor

We probably need to run make update-modules to update the version in the modules.

@dmathieu
Copy link
Member Author

Thanks, and you are right. Unfortunately, I can't do that right away due to apmotel not being compatible with Go 1.15 (which is expected).
I've opened #1418 to fix that issue.

@dmathieu dmathieu force-pushed the release-2-4-0 branch 2 times, most recently from e1d537a to 8561300 Compare April 27, 2023 07:59
@dmathieu
Copy link
Member Author

Modules have been updated.

Copy link
Contributor

@lahsivjar lahsivjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one missed (not sure why the update-modules didnt' pick it up)

internal/apmgodog/go.mod Outdated Show resolved Hide resolved
@dmathieu dmathieu merged commit 27a3571 into elastic:main Apr 27, 2023
@dmathieu dmathieu deleted the release-2-4-0 branch April 27, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants