Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore instrumentation nav #1371

Merged
merged 1 commit into from
Jan 18, 2023
Merged

restore instrumentation nav #1371

merged 1 commit into from
Jan 18, 2023

Conversation

graphaelli
Copy link
Member

https://www.elastic.co/guide/en/apm/agent/go/current/index.html currently renders as:

image

with module/apmpgx at the top level in the navigation. This should restore the instrumentation navigation expected in the docs

@apmmachine
Copy link
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-18T20:26:15.303+0000

  • Duration: 1 min 43 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@graphaelli
Copy link
Member Author

preview looks good
image

@graphaelli
Copy link
Member Author

@bmorelli25 is there a handy way to port this to 2.x also?

@graphaelli graphaelli merged commit fb87682 into elastic:main Jan 18, 2023
@graphaelli graphaelli deleted the update-nav branch January 18, 2023 21:38
@bmorelli25
Copy link
Member

💚 All backports created successfully

Status Branch Result
2.x

Questions ?

Please refer to the Backport tool documentation

@bmorelli25
Copy link
Member

@bmorelli25 is there a handy way to port this to 2.x also?

I use the backport tool for these: backport --pr 1371 --branch 2.x

bmorelli25 pushed a commit to bmorelli25/apm-agent-go that referenced this pull request Jan 18, 2023
@graphaelli
Copy link
Member Author

excellent, thanks!

bmorelli25 added a commit that referenced this pull request Jan 18, 2023
(cherry picked from commit fb87682)

Co-authored-by: Gil Raphaelli <[email protected]>
@axw
Copy link
Member

axw commented Jan 18, 2023

Oops. Thanks @graphaelli & @bmorelli25!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants