Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure a minimum retry interval of 5 seconds in fetching central configuration #1337

Merged
merged 3 commits into from
Nov 28, 2022
Merged

fix: ensure a minimum retry interval of 5 seconds in fetching central configuration #1337

merged 3 commits into from
Nov 28, 2022

Conversation

kruskall
Copy link
Member

Update config retrieval logic to ignore any max age header below 5 seconds and replacing it with 5s to ensure a minimum retry interval.

Closes #1322
See elastic/apm#690
See #1322

@kruskall
fix: ensure a minimum retry interval of 5 seconds in fetching central…
cb77723 
… configuration

Update config retrieval logic to ignore any max age header below 5 seconds
and replacing it with 5s to ensure a minimum retry interval.
@apmmachine
Copy link
Contributor

apmmachine commented Oct 19, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-28T09:10:36.919+0000

  • Duration: 59 min 4 sec

Test stats 🧪

Test Results
Failed 0
Passed 8688
Skipped 215
Total 8903

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

axw
axw reviewed Oct 24, 2022
View reviewed changes
transport/http.go Outdated Show resolved Hide resolved
@apmmachine
Copy link
Contributor

apmmachine commented Nov 21, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (60/60) 💚
Files 99.355% (154/155) ❕
Classes 96.317% (340/353) ❕
Methods 90.349% (983/1088) ❕
Lines 82.2% (11448/13927) ❕
Conditionals 100.0% (0/0) 💚

@kruskall kruskall enabled auto-merge (squash) November 22, 2022 09:24
@kruskall
Copy link
Member Author

/test

@kruskall kruskall merged commit c4dcc40 into elastic:main Nov 28, 2022
@kruskall kruskall deleted the fix/minimum-retry-interval branch March 30, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
agent-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META 690] Ensure a minimum retry interval of 5 seconds in fetching central configuration
4 participants
@kruskall @apmmachine @axw @simitt