Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ignore *principal* headers by default #1332

Merged
merged 2 commits into from
Oct 10, 2022
Merged

feat: ignore *principal* headers by default #1332

merged 2 commits into from
Oct 10, 2022

Conversation

kruskall
Copy link
Member

Update sanitization rule to ignore principal headers by default. Update documentation with the new default values.

Mostly related to Azure SSO and potential exposure of PII.

Closes #1316

Spec: elastic/apm#680

@kruskall
feat: ignore *principal* headers by default
c43beb5 
Update sanitization rule to ignore *principal* headers by default.
Update documentation with the new default values.

Mostly related to Azure SSO and potential exposure of PII.
axw
axw approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please add a changelog entry for this?

@apmmachine
Copy link
Contributor

apmmachine commented Oct 10, 2022 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-10T10:06:15.338+0000

  • Duration: 56 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 8554
Skipped 201
Total 8755

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Oct 10, 2022 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (59/59) 💚
Files 99.346% (152/153) 👍
Classes 96.275% (336/349) 👍
Methods 90.49% (961/1062) 👍
Lines 82.249% (11204/13622) 👎 -0.029
Conditionals 100.0% (0/0) 💚

@kruskall
Copy link
Member Author

Added a changelog entry 👍

@kruskall kruskall enabled auto-merge (squash) October 10, 2022 08:17
@kruskall
Copy link
Member Author

/test

@kruskall kruskall merged commit f9f8ce3 into elastic:main Oct 10, 2022
@kruskall kruskall deleted the feat/ignore-principal branch October 10, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axw axw axw approved these changes

Assignees
No one assigned
Labels
agent-go
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[META 689] Ignore *principal* headers by default
3 participants
@kruskall @apmmachine @axw