-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add panic propagation option to gin middleware #1314
Conversation
💚 CLA has been signed |
I did sign the contribution guidelines. Does this take some time before it gets picked up? |
@miguelb thanks for opening the PR! It looks like your commit is not associated with the email you used to sign the CLA. I think what you need to do is configure |
5405000
to
a37954b
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks :)
/test |
🌐 Coverage report
|
run elasticsearch-ci/docs |
If gin middleware catches a panic it bypasses other middleware panic handlers. This is an issue in our use case because we have middleware which sends panics to our notification/alert system. The changes in this PR is modeled from other modules which support
panicPropagation
.