Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add testcase for sqs delete_batch operation #1283

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Aug 6, 2022

Assert 'span.name' and 'span.action' are following the
spec for delete_batch operations.

The actions were not described in the original spec but
the output seems to be correct so we just add a test to
avoid regressions and verification.

Closes #1170

Assert 'span.name' and 'span.action' are following the
spec for delete_batch operations.

The actions were not described in the original spec but
the output seems to be correct so we just add a test to
avoid regressions and verification.
@apmmachine
Copy link
Contributor

apmmachine commented Aug 6, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-08-08T17:11:52.923+0000

  • Duration: 52 min 8 sec

Test stats 🧪

Test Results
Failed 0
Passed 8470
Skipped 201
Total 8671

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run benchmark tests : Run the benchmark test.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@apmmachine
Copy link
Contributor

apmmachine commented Aug 8, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (59/59) 💚
Files 99.346% (152/153)
Classes 96.275% (336/349)
Methods 90.198% (957/1061)
Lines 82.227% (11122/13526)
Conditionals 100.0% (0/0) 💚

@kruskall
Copy link
Member Author

kruskall commented Aug 8, 2022

/test

@kruskall kruskall merged commit 0f2b9ce into elastic:main Aug 8, 2022
@kruskall kruskall deleted the test/sqs-delete-batch branch August 8, 2022 18:50
v1v added a commit to v1v/apm-agent-go that referenced this pull request Sep 1, 2022
…hmark-reporting

* upstream/main: (25 commits)
  docs: update correct env flag for loglevel (elastic#1299)
  fix: readd deprecated span_frames_min_duration option as fallback for older configuration (elastic#1297)
  feat: rename span_frames_min_duration to span_stack_trace_min_duration (elastic#1285)
  test: verify Ubuntu cgroup line parsing for container ID (elastic#1293)
  tracer: Parse global labels per tracer (elastic#1290)
  feat: update sns span.name to reflect the current spec (elastic#1286)
  fix: expand k8s pod discovery regex (elastic#1288)
  test: add testcase for sqs delete_batch operation (elastic#1283)
  docs: document ELASTIC_APM_SERVER_CA_CERT_FILE (elastic#1289)
  fix: reformat code with go 1.19 to fix ci failure  (elastic#1284)
  feat: add service target fields support to elasticsearch module (elastic#1281)
  fix: use the correct destination resource and name for azure queue (elastic#1282)
  feat: add service target fields support to azure module (elastic#1280)
  feat: add service target fields support to aws module (elastic#1278)
  feat: add service target fields support to sql module (elastic#1279)
  synchronize json schema specs (elastic#1260)
  fix: make sure at least one of the service target fields is sent (elastic#1277)
  docs: add link to release-notes-2.x (elastic#1271)
  feat: add service target fields (elastic#1274)
  perf: skip tracestate regex validation for es vendor key (elastic#1275)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update instrumentation of SQS for batch send, delete, and batch delete operations
3 participants