-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: default to custom for empty transaction and span types #1272
fix: default to custom for empty transaction and span types #1272
Conversation
According to the spec: If no transaction.type or span.type is provided or the value is an empty string, the agent needs to set a default value custom. Add test to assert the behaviour is compliant to the spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the module/apmot
tests are failing, as they are depending on Type to be empty after construction.
Maybe there's a better alternative, but we I think we may need to set this default value when ending the transaction or span, if the value is empty. That's a bit more foolproof anyway, since users could directly set Type = ""
after starting the transaction or span.
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
this should also fix this one elastic/kibana#126805 |
According to the spec:
If no transaction.type or span.type is provided or the value
is an empty string, the agent needs to set a default value
custom.
Add test to assert the behaviour is compliant to the spec.
Closes #1211