-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement Span Links API #1269
Conversation
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
🌐 Coverage report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
We'll need to add this for transactions too.
Can you please also add tests (one for spans, one for transactions)? We should show that the span links are included in the events sent, which we can verify using the apmtest.RecordingTracer. See span_test.go
and transaction_test.go
for examples. Since the spec says "Links SHOULD preserve the order in which they are set", it would be good to show that in the tests too.
Assert spanlinks are included in the final events and make sure span link order is preserved.
Thank you for the feedback! 🙇 I've pushed some changes and added the tests.
Thank you for pointing this out, I reread the spec and I completely missed that part 🤦 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good. I'd like to see the tests simplified, but otherwise LGTM.
Thanks for the feedback! I've pushed some changes 🏓 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a suggestion about the test, I'll leave it to you to decide which way you prefer.
/test |
/test |
This is an attempt to implement the Span Links API, mostly inspired by other PRs to the other agents and the spec/docs for OT.
Closes #1243